chore: remove solidity packages and conf #286
Conversation
|
@sripwoud @baumstern It would be nice to have your feedback for files related to turbo and workflows. |
|
Not related to this PR, but to the new |
Co-authored-by: sripwoud <[email protected]>
Co-authored-by: sripwoud <[email protected]>
Co-authored-by: sripwoud <[email protected]>
Co-authored-by: sripwoud <[email protected]>
Co-authored-by: sripwoud <[email protected]>
turbo.json
Outdated
| "@zk-kit/imt#build", | ||
| "@zk-kit/lean-imt#build", | ||
| "@zk-kit/baby-jubjub#build", | ||
| "@zk-kit/eddsa-poseidon#build", | ||
| "@zk-kit/lazytower#build", | ||
| "@zk-kit/poseidon-cipher#build", | ||
| "@zk-kit/poseidon-proof#build", | ||
| "@zk-kit/smt#build", | ||
| "@zk-kit/utils#build" |
There was a problem hiding this comment.
@sripwoud Is there a way to avoid listing all packages here? Isn't it possible to put 1 command somehow?
There was a problem hiding this comment.
Hmm I don't remember why I wrote this but there must have been a reason.
I remember it had to do with dealing with a root task and wanting to specify some workspace tasks as dependencies.
So I ended using this syntax
https://turbo.build/repo/docs/core-concepts/monorepos/task-dependencies#from-arbitrary-workspaces
now we use the root test task that needs everything to be build first.
So did you try simply?
"//#test":{ "dependsOn": ["build"] ...}
I've not added it because I've not studied it yet. But if you think they could benefit from it please test them! |
turbo.json
Outdated
| "@zk-kit/imt#build", | ||
| "@zk-kit/lean-imt#build", | ||
| "@zk-kit/baby-jubjub#build", | ||
| "@zk-kit/eddsa-poseidon#build", | ||
| "@zk-kit/lazytower#build", | ||
| "@zk-kit/poseidon-cipher#build", | ||
| "@zk-kit/poseidon-proof#build", | ||
| "@zk-kit/smt#build", | ||
| "@zk-kit/utils#build" |
There was a problem hiding this comment.
Hmm I don't remember why I wrote this but there must have been a reason.
I remember it had to do with dealing with a root task and wanting to specify some workspace tasks as dependencies.
So I ended using this syntax
https://turbo.build/repo/docs/core-concepts/monorepos/task-dependencies#from-arbitrary-workspaces
now we use the root test task that needs everything to be build first.
So did you try simply?
"//#test":{ "dependsOn": ["build"] ...}
Description
This PR removes all code related to Solidity as it has been moved to another ZK-Kit repository: https://github.com/privacy-scaling-explorations/zk-kit.solidity.
It also optimizes the Github workflows and removes legacy JS packages (
groth16androllup-plugin-rust).Related Issue(s)
Closes #282
Checklist
yarn stylewithout getting any errors